The clear and obvious question here is if it's "just metadata" and isn't really spying, then why is it secret at all? In fact, why don't we broadcast to the terrorists that we do this and wish them luck attacking us without the aid of electronic communication.

The secrecy only makes it look like something illegal. (And there is no doubt in my mind that it is against the spirit of American law, if not the letter)